Re: [PATCH 2/6] vt: push down the tty lock so we can see what is left to tackle

[PATCH 0/6] Remove tty_lock from the console drivers · Alan Cox <hidden> · 2012-03-01
[PATCH 1/6] vt: sort out locking for font handling · Alan Cox <hidden> · 2012-03-01
[PATCH 2/6] vt: push down the tty lock so we can see what is left to tackle · Alan Cox <hidden> · 2012-03-01
Re: [PATCH 2/6] vt: push down the tty lock so we can see what is left to tackle · Jiri Slaby <hidden> · 2012-03-01
Re: [PATCH 2/6] vt: push down the tty lock so we can see what is left to tackle · Arnd Bergmann <arnd@arndb.de> · 2012-03-01
[PATCH 3/6] vt: push down tioclinux cases · Alan Cox <hidden> · 2012-03-01
[PATCH 4/6] vt: waitevent is self locked so drop the tty_lock · Alan Cox <hidden> · 2012-03-01
[PATCH 5/6] vt: tackle the main part of the selection logic · Alan Cox <hidden> · 2012-03-01
[PATCH 6/6] vt: push the tty_lock down into the map handling · Alan Cox <hidden> · 2012-03-01
Re: [PATCH 0/6] Remove tty_lock from the console drivers · Arnd Bergmann <arnd@arndb.de> · 2012-03-01

From: Jiri Slaby <hidden>
Date: 2012-03-01 20:31:16
Also in: lkml

On 03/01/2012 08:50 PM, Alan Cox wrote:

quoted hunk ↗ jump to hunk

--- a/drivers/tty/vt/vt_ioctl.c
+++ b/drivers/tty/vt/vt_ioctl.c

@@ -281,7 +281,6 @@ int vt_ioctl(struct tty_struct *tty,
 
 	console = vc->vc_num;
 
-	tty_lock();

Note that this breaks bisection. Further in vt_ioctl, there is a call to
vt_event_wait_ioctl which calls vt_event_wait and that calls
wait_event_interruptible_tty which unlocks BTM.

You change wait_event_interruptible_tty to wait_event_interruptible even
in 4/6.

The VT_WAITEVENT case should have tty_lock until 4/6 (and not longer).

thanks,
-- 
js
suse labs

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help