On 12-03-02 06:22 AM, Alan Cox wrote:

On Thu,  1 Mar 2012 21:33:21 -0500
Paul Gortmaker [off-list ref] wrote:

quoted

The two callers to serial_out_sync() have a struct port right
there in scope, but then pass in a struct 8250_port which then
is locally resolved to a struct port.

This change I don't like. It means serial_out_sync and serial_out end
up with different parameters which seems odd to say the least. You then
extend this oddity by adding helpers for port_in/out but not the sync
one.

I can't argue that.  I'll reorder it so the generic serial_port_X
helpers are introduced 1st, and then amend this to rename the fcn
from serial_out_sync to serial_port_out_sync.   Or I could just
drop is commit entirely.  Any preference one way or the other?

Thanks for the review.
Paul.

Otherwise it all looks good to me.

Alan