Re: [Patch] tty: fix a build failure on sparc
From: Paul Gortmaker <hidden>
Date: 2012-02-03 19:46:21
Also in:
lkml
[Resending with updated address for Greg] On 12-02-03 12:22 AM, Cong Wang wrote:
On sparc, there is a build failure: drivers/tty/serial/8250/8250.c:48:21: error: suncore.h: No such file or directory drivers/tty/serial/8250/8250.c:3275: error: implicit declaration of function 'sunserial_register_minors' drivers/tty/serial/8250/8250.c:3305: error: implicit declaration of function 'sunserial_unregister_minors' this is due to commit 9bef3d4197379a995fa80f81950bbbf8d32e9e8b (serial: group all the 8250 related code together) moved these files into 8250/ subdirectory, but forgot to change the reference to drivers/tty/serial/suncore.h.
Thanks, I explicitly left sunsu out of the move but missed that 8250 was sourcing its related header. I did defconfig builds, but in going back to check, I see that neither sparc 32/64 defconfig enable 8250 by default, so those builds didn't help me much at all... :( Acked-by: Paul Gortmaker <redacted>
quoted hunk ↗ jump to hunk
Cc: Paul Gortmaker <redacted> Cc: Greg Kroah-Hartman <gregkh@suse.de> Signed-off-by: WANG Cong <redacted> ---diff --git a/drivers/tty/serial/8250/8250.c b/drivers/tty/serial/8250/8250.c index 9f50c4e..9b7336f 100644 --- a/drivers/tty/serial/8250/8250.c +++ b/drivers/tty/serial/8250/8250.c@@ -45,7 +45,7 @@ #include "8250.h" #ifdef CONFIG_SPARC -#include "suncore.h" +#include "../suncore.h" #endif /*