Re: [PATCH 2/4] qcserial: log when an interface has too many altsettings
From: Greg KH <gregkh@linuxfoundation.org>
Date: 2012-02-01 21:19:51
On Wed, Feb 01, 2012 at 04:07:23PM -0500, Thomas Tuttle wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Thomas Tuttle <redacted> --- drivers/usb/serial/qcserial.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-)diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c index 26e3e30..5a817d6 100644 --- a/drivers/usb/serial/qcserial.c +++ b/drivers/usb/serial/qcserial.c@@ -145,8 +145,12 @@ static int qcprobe(struct usb_serial *serial, const struct usb_device_id *id) /* Gobi 2000 has a single altsetting, older ones have two */ if (serial->interface->num_altsetting == 2) intf = &serial->interface->altsetting[1]; - else if (serial->interface->num_altsetting > 2) + else if (serial->interface->num_altsetting > 2) { + dev_err(&serial->dev->dev, + "too many altsettings: %u", + serial->interface->num_altsetting);
Why would this happen? And what does spitting out an error do about it? What are we supposed to do with this information? thanks, greg k-h