Re: [PATCH 3/3] serial: 8250: Add a wakeup_capable module param

Hi Alan,

On Wed, Jan 18, 2012 at 2:12 PM, Alan Cox [off-list ref] wrote:

quoted

Let me provide a bit of context. The serial_core code seems to be the
only place in the kernel that does this:

              device_init_wakeup(tty_dev, 1);
              device_set_wakeup_enable(tty_dev, 0);

The first call makes the device wakeup capable and enables wakeup, The
second call disabled wakeup.

quoted

I assume we can't and shouldn't change device_init_wakeup() . We could
add a call like device_init_wakeup_disabled() which makes the device
wakeup capable but does not actually enable it. Does that work?

Is that not

       device_init_wakeup(tty_dev, 0)

or am I missing something ?

Bearing in mind that I know very little about this, I think
serial_core wants to have the device wakeup capable in any case, but
not actually enable wakeup on the device until requested. It seems
that drivers rely on that behaviour too.

device_init_wakeup(tty_dev, 0) calls device_set_wakeup_capable(dev,
false) which I think is not what we want.

Regards,
Simon
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html