Re: [PATCH] serial: samsung: Fix build for non-Exynos4210 devices
From: Thomas Abraham <hidden>
Date: 2011-11-06 16:13:46
Also in:
lkml
Hi Mark, On 4 November 2011 22:46, Mark Brown [off-list ref] wrote:
exynos4120_serial_drv_data is only defined when building with support for Exynos4210 so use the already provided define to ensure that we don't reference it when building for other SoCs. Signed-off-by: Mark Brown <redacted>
I missed that one. Thanks for the fix. The Samsung device tree patches will not be merged in v3.2 merge window. So should this fix be merged into the uart dt support patch or should this be a separate patch? Thanks, Thomas.
quoted hunk ↗ jump to hunk
--- drivers/tty/serial/samsung.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c index efe3756..7272eee 100644 --- a/drivers/tty/serial/samsung.c +++ b/drivers/tty/serial/samsung.c@@ -1649,7 +1649,7 @@ MODULE_DEVICE_TABLE(platform, s3c24xx_serial_driver_ids);#ifdef CONFIG_OF static const struct of_device_id s3c24xx_uart_dt_match[] = { { .compatible = "samsung,exynos4210-uart", - .data = &exynos4210_serial_drv_data }, + .data = EXYNOS4210_SERIAL_DRV_DATA }, {}, }; MODULE_DEVICE_TABLE(of, s3c24xx_uart_dt_match); -- 1.7.7.1