Re: [PATCH 2/2] pch_uart: Delete modem status interrupt enable code
From: Tomoya MORINAGA <hidden>
Date: 2011-11-02 05:52:57
Also in:
lkml
From: Tomoya MORINAGA <hidden>
Date: 2011-11-02 05:52:57
Also in:
lkml
(2011/11/01 21:57), Alan Cox wrote:
quoted
(pch_uart device has auto hardware flow control function. So, pch_uart driver doesn't have to control modem status interrupt.)This is true for flow control bits but not for incoming carrier detect ?
Called ".get_mctrl" function, other software can know incoming carrier detection. Or you mean a uart driver must detect incoming carrier with interrupt ?
quoted
This patch deletes the code.quoted
+ dev_info(priv->port.dev, + "PCH UART : Modem status interrupt is not supported.\n"); }dev_info seems wrong here. Does the user need to know this ?
OK, a user doesn't have to know the information. I will delete the dev_info. Thanks, -- tomoya ROHM Co., Ltd.