On Thu, Sep 1, 2011 at 2:35 PM, Geert Uytterhoeven [off-list ref] wrote:

On Thu, Sep 1, 2011 at 08:14, WANG Cong [off-list ref] wrote:

quoted

KERN_CRIT is too high, replace those KERN_CRIT with KERN_ERR or KERN_INFO.

Cc: Mikael Starvik <redacted>
Cc: Jesper Nilsson <jesper.nilsson@axis.com>
Signed-off-by: WANG Cong <redacted>

---

diff --git a/drivers/tty/serial/crisv10.c b/drivers/tty/serial/crisv10.c
index 225123b..77ba4ed 100644
--- a/drivers/tty/serial/crisv10.c
+++ b/drivers/tty/serial/crisv10.c

@@ -1788,7 +1788,7 @@ static unsigned int handle_descr_data(struct e100_serial *info,

       struct etrax_recv_buffer *buffer = phys_to_virt(descr->buf) - sizeof *buffer;

       if (info->recv_cnt + recvl > 65536) {
-               printk(KERN_CRIT
+               printk(KERN_INFO
                      "%s: Too much pending incoming serial data! Dropping %u bytes.\n", __func__, recvl);
               return 0;
       }

I think dropped data warrants KERN_WARN.

Yeah, agreed! I will update this patch shortly.

Thanks.