Re: [PATCH v3] pch_uart: Add MSI support
From: Tomoya MORINAGA <hidden>
Date: 2011-07-22 12:39:08
Also in:
lkml
(2011/07/04 15:58), Alexander Stein wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Alexander Stein<redacted> --- Hello Greg, I'm sorry. This patch was based some other patches, like console support. Changes in v3: * Rebased to current git master drivers/tty/serial/pch_uart.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)diff --git a/drivers/tty/serial/pch_uart.c b/drivers/tty/serial/pch_uart.c index 4652109..d3ba85b 100644 --- a/drivers/tty/serial/pch_uart.c +++ b/drivers/tty/serial/pch_uart.c@@ -1429,6 +1429,8 @@ static struct eg20t_port *pch_uart_init_port(struct pci_dev *pdev, goto init_port_hal_free; } + pci_enable_msi(pdev); + iobase = pci_resource_start(pdev, 0); mapbase = pci_resource_start(pdev, 1); priv->mapbase = mapbase;@@ -1485,6 +1487,8 @@ static void pch_uart_pci_remove(struct pci_dev *pdev) struct eg20t_port *priv; priv = (struct eg20t_port *)pci_get_drvdata(pdev); + + pci_disable_msi(pdev); pch_uart_exit_port(priv); pci_disable_device(pdev); kfree(priv);@@ -1568,6 +1572,7 @@ static int __devinit pch_uart_pci_probe(struct pci_dev *pdev, return ret; probe_disable_device: + pci_disable_msi(pdev); pci_disable_device(pdev); probe_error: return ret;
Using this patch, PCH_UART doesn't work all. For using MSI, I think, need bus master enable(pci_set_master) ? Best Regards, -- tomoya OKI SEMICONDUCTOR CO., LTD.