Thread (9 messages) 9 messages, 3 authors, 2011-06-21

Re: [PATCH] atmel_serial: keep the platform_device unchanged

From: Jean-Christophe PLAGNIOL-VILLARD <hidden>
Date: 2011-06-08 14:40:40
Also in: linux-arm-kernel, lkml

On 10:45 Wed 08 Jun     , Hans-Christian Egtvedt wrote:
On Wed, 2011-04-13 at 21:47 +0200, Jean-Christophe PLAGNIOL-VILLARD
wrote:
quoted
specify the port num via platform_data this will allow to match the clock
with the plaform_dev staticly
Sure this works as intended, now the platform device id is off, and at
least for my 3.0 testing it is no longer able to open the console,
unless I explicit set the id field again.

Example on NGW100 mkII I use USART instance 1 as serial console, if not
setting the platform device id to 0 (re-mapping), then I get a warning
about unable to open console.

Is you clock optimization an additional patch?
no but we can also switch the avr32 to clkdev
<snipp AT91 changes)
quoted
diff --git a/arch/avr32/mach-at32ap/at32ap700x.c b/arch/avr32/mach-at32ap/at32ap700x.c
index bfc9d07..aa677e2 100644
--- a/arch/avr32/mach-at32ap/at32ap700x.c
+++ b/arch/avr32/mach-at32ap/at32ap700x.c
@@ -1014,6 +1014,7 @@ static struct platform_device *__initdata at32_usarts[4];
 void __init at32_map_usart(unsigned int hw_id, unsigned int line, int flags)
 {
 	struct platform_device *pdev;
+	struct atmel_uart_data *pdata;
 
 	switch (hw_id) {
 	case 0:
@@ -1042,7 +1043,8 @@ void __init at32_map_usart(unsigned int hw_id, unsigned int line, int flags)
 		data->regs = (void __iomem *)pdev->resource[0].start;
 	}
 
-	pdev->id = line;
AVR32 needs this to be present to work independent of which USART
peripheral the user chooses to use for console.
quoted
+	pdata = pdev->dev.platform_data;
+	pdata->num = portnr;
here supposed to be
	pdata->num = line;

Best Regards,
J.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help