Re: [PATCH] Add sc16is7x2 driver
From: Greg KH <hidden>
Date: 2010-09-21 20:47:50
Also in:
lkml
On Tue, Sep 14, 2010 at 03:07:13PM +0200, Manuel Stahl wrote:
quoted hunk ↗ jump to hunk
--- a/include/linux/serial_core.h +++ b/include/linux/serial_core.h@@ -47,6 +47,9 @@ #define PORT_U6_16550A 19 /* ST-Ericsson U6xxx internal UART */ #define PORT_MAX_8250 19 /* max port ID */ +/* SC16IS7x2 SPI UART */ +#define PORT_SC16IS7X2 19
Hm, didn't you just duplicate the number here? Shouldn't that be "20" and you bump the max up? In the end, we need to just drop those, I don't think we need defines anymore, but I need to look at it some more to find out. thanks, greg k-h