Re: [PATCH] Enable legacy support for serial ports when SERIAL_8250_PNP is disabled
From: Bjorn Helgaas <hidden>
Date: 2007-07-11 21:15:30
Also in:
lkml
From: Bjorn Helgaas <hidden>
Date: 2007-07-11 21:15:30
Also in:
lkml
On Wednesday 11 July 2007 01:40:07 pm Luca wrote:
On 7/9/07, Bjorn Helgaas [off-list ref] wrote:quoted
On Monday 09 July 2007 11:30:59 am Luca wrote:quoted
On 7/9/07, Bjorn Helgaas [off-list ref] wrote:quoted
If you turn off PNP completely, you will have "pnp_platform_devices == 0", and the existing code will do what you need.Well for me it's a non-issue, I'm able to "work-around" it in many ways. My point is that a configuration that used to work and is still valid suddenly doesn't work anymore.You're right about that, and it is a legitimate issue. But given the fact that (PNP && !SERIAL_8250_PNP) should be relatively unusual, my opinion is that it's not worth extra ifdefs in legacy_serial.c. If you have to use any workarounds like "legacy_serial.force", I think that's a bug, and I'll fix it.Ok, I double-checked: the serial port is usable during boot with PNP enabled, so no problem with dropping my patch.
Thanks a lot for checking! Bjorn