Re: [PATCH] genericserial: Remove bogus optimisation check and dead code paths
From: Alan Cox <hidden>
Date: 2007-07-03 15:20:55
Also in:
lkml
From: Alan Cox <hidden>
Date: 2007-07-03 15:20:55
Also in:
lkml
On Tue, 03 Jul 2007 16:39:05 +0200 Morten Helgesen [off-list ref] wrote:
Alan Cox wrote: [...snip...]quoted
@@ -75,11 +64,11 @@ if (! (port->flags & ASYNC_INITIALIZED)) return; /* Take a lock on the serial tranmit buffer! */ - LOCKIT; + mutex_lock(& port->port_write_mutex);^ Contains additional whitespace.
Its an old driver, it doesn't follow the coding style too well at all - viz stuff like if (! ( the line above. Given its age and limited userbase I don't plan to go and make it conform either, but I will take patches for the formatting (and the spelling errors it is full of) from someone who wants to do the work. Alan