Hello.

Marc St-Jean wrote:

quoted

quoted

quoted

quoted

Fourth attempt at the serial driver patch for the PMC-Sierra MSP71xx

device.

quoted

   I think you need to submit your patch to Andrew Morton since it 
requires a patch from his tree.

OK, will do.

    In fact, since the serial drivers are not maintained anymore, this seems 
the only option.

quoted

quoted

quoted

quoted

+                     /* The DesignWare APB UART has an Busy Detect

(0x07)

quoted

+                      * interrupt meaning an LCR write attempt

occured while the

quoted

+                      * UART was busy. The interrupt must be cleared

by reading

quoted

+                      * the UART status register (USR) and the LCR

re-written. */

quoted

+                     unsigned int status;
+                     status = *(volatile u32 

*)up->port.private_data;

quoted

quoted

quoted

+                     serial_out(up, UART_LCR, up->lcr);
+
+                     handled = 1;
+
+                     end = NULL;
              } else if (end == NULL)
                      end = l;

quoted

quoted

quoted

quoted

      return 0;

quoted

quoted

quoted

   Still, shouldn't you be doing this in serial8250_timeout()

quoted

quoted

No, the serial8250_timeout is for issue 1 at the top, this is for
issue 2.

quoted

   It's for lost interrupts, IIUC. They use anothe timeout handler for the
workaround...

This issue (2) is a completely new type of interrupt generated but the
DesignWare APB uart, it has nothing to do with lost interrupts.

    Yeah, I just thought that the lost interrupts might be a "generic" issue.

quoted

quoted

quoted

also?
What IRQ numbers this UART is using, BTW?

quoted

quoted

For the ports on the device they are 27 and 42. Is there any 

significance

quoted

that I'm not aware of?

quoted

   Yeah, IRQ0 is treated as no IRQ by 8250, and in this case it falls 
back to using serial8250_timeout() to handle "interrupts".

Good to know. It won't be affecting us then.

    This may be overriden anyway...

quoted

quoted

quoted

   Oops, your mailer went and did it again. :-)

quoted

quoted

I'm completely giving up on Thunderbird,unless someone can point out

quoted

   Ypu should have long ago. :-)

quoted

quoted

the specific internal configuration items which needs a kick!

quoted

   Only the attachments will work in the Mozilla kind mailer, AFAIK.
The last patch looked OK at last. :-)

The attachemnents appear to be MIME which is a no-no according the

    The text/plain type attachments seem to be acceptable for the most 
maintainers.  This Mozilla can do, at least. :-)

linux FAQ at kernel.org. I guess I'll stick with /bin/mail.

Thanks,
Marc

WBR, Sergei