Re: [RFC][PATCH] Xilinx uartlite serial driver
From: Olof Johansson <hidden>
Date: 2006-10-19 23:08:08
Also in:
lkml
Possibly related (same subject, not in this thread)
- 2006-10-20 · Re: [RFC][PATCH] Xilinx uartlite serial driver · Peter Korsgaard <jacmet@sunsite.dk>
- 2006-10-13 · Re: [RFC][PATCH] Xilinx uartlite serial driver · Peter Korsgaard <jacmet@sunsite.dk>
- 2006-10-13 · Re: [RFC][PATCH] Xilinx uartlite serial driver · David H. Lynch Jr. <hidden>
- 2006-10-06 · Re: [RFC][PATCH] Xilinx uartlite serial driver · David H. Lynch Jr. <hidden>
- 2006-10-06 · Re: [RFC][PATCH] Xilinx uartlite serial driver · David H. Lynch Jr. <hidden>
On Wed, 13 Sep 2006 15:39:09 +0200 Peter Korsgaard [off-list ref] wrote:
+static int __devinit ulite_probe(struct platform_device *pdev)
[...]
+ port = &ports[pdev->id]; + + port->fifosize = 16; + port->regshift = 2; + port->iotype = UPIO_MEM; + port->iobase = 1; /* mark port in use */ + port->mapbase = res->start; + port->membase = 0; + port->ops = &ulite_ops; + port->irq = res2->start; + port->flags = UPF_BOOT_AUTOCONF; + port->dev = &pdev->dev; + port->type = PORT_UNKNOWN;
Hi Peter, You never fill in the 'line' member here, so probing of a second uartlite port will fail. Add: port->line = pdev->id; -Olof