Re: [ patch 6/7] drivers/serial/jsm: new serial device driver
From: Christoph Hellwig <hch@infradead.org>
Date: 2005-02-28 03:22:42
Also in:
lkml
On Sun, Feb 27, 2005 at 07:47:58PM -0500, Jeff Garzik wrote:
quoted
+struct shrink_buf_struct { + unsigned int shrink_buf_vaddr; /* Virtual address of board */ + unsigned int shrink_buf_phys; /* Physical address of board */Major bug. These should be unsigned long.
not sure what they actually mean, but a virtual address should be a void * and drivers shouldn't ever mess with physical addresses.