Re: [PATCH -next -v2 3/8] lockdown: select SECURITYFS

From
sashiko-bot@kernel.org
Date
2026-11-10 13:05:38
Also in
bpf
Reply to
Cai Xinchen, 2026-11-10
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] lockdown: missing Fixes trailer for commit 000d388ed3bb
--

commit 721e2eb133b0424c2cffa079b553baff1406aa9c
Author: Cai Xinchen [off-list ref]
lockdown: select SECURITYFS

The lockdown LSM exposes /sys/kernel/security/lockdown, but it does not
select SECURITYFS.  If SECURITYFS is disabled, securityfs_create_file()
returns -ENODEV, lockdown_secfs_init() fails and the LSM framework logs:

  failed LSM lockdown core initcall with errno -19

while the sysfs interface advertised by the Kconfig help text is missing.

Select SECURITYFS like the other LSMs that create securityfs entries
(AppArmor, SafeSetID, TOMOYO and IMA) already do.

Signed-off-by: Cai Xinchen <redacted>
[Severity: Low]
This fixes the missing SECURITYFS dependency in SECURITY_LOCKDOWN_LSM.
Should this include:

  Fixes: 000d388ed3bb ("security: Add a static lockdown policy LSM")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261110132818.2231593-1-caixinchen1@huawei.com?part=3
Thread (18 messages) 18 messages, 3 authors, last reply 6d ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help