Re: [PATCH 03/13] mm/rmap: convert remaining VMA flag tests to use vma_flags_t

From
Barry Song <baohua@kernel.org>
Date
2026-11-06 03:57:21
Also in
damon, kvm, linux-fsdevel, linux-integrity, linux-mm, linux-perf-users, linux-trace-kernel, linuxppc-dev, lkml, selinux
Reply to
Lorenzo Stoakes (ARM), 2026-11-05
On Fri, Nov 6, 2026 at 5:32 AM Lorenzo Stoakes (ARM) [off-list ref] wrote:
Replace the remaining uses of the legacy vm_flags_t flags in the rmap logic
with vma_flags_t values.

No functional change intended.

Signed-off-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
---
LGTM,

Reviewed-by: Barry Song <baohua@kernel.org>
quoted hunk ↗ jump to hunk
 mm/rmap.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/mm/rmap.c b/mm/rmap.c
index 1131b76bbbc2..cdc97fec8586 100644
--- a/mm/rmap.c
+++ b/mm/rmap.c
@@ -1196,7 +1196,7 @@ static bool page_mkclean_one(struct folio *folio, struct vm_area_struct *vma,

 static bool invalid_mkclean_vma(struct vm_area_struct *vma, void *arg)
 {
-       if (vma->vm_flags & VM_SHARED)
+       if (vma_test(vma, VMA_SHARED_BIT))
                return false;

        return true;
@@ -1660,7 +1660,8 @@ void folio_add_new_anon_rmap(struct folio *folio, struct vm_area_struct *vma,
         * VM_DROPPABLE mappings don't swap; instead they're just dropped when
         * under memory pressure.
         */
-       if (!folio_test_swapbacked(folio) && !(vma->vm_flags & VM_DROPPABLE))
+       if (!folio_test_swapbacked(folio) &&
+           !vma_test_single_mask(vma, VMA_DROPPABLE))
Right, VMA_DROPPABLE_BIT is not available on
32-bit architectures, so vma_test() cannot be
used here.
Thread (77 messages) 77 messages, 11 authors, last reply 16h ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help