Re: [PATCH v2 07/27] selftests/landlock: Fix the ruleset_fd check in empty_or_same_ruleset

From: sashiko-bot@kernel.org
Date: 2026-11-04 21:12:26
Reply to: Günther Noack, 2026-11-04

ASSERT_LE(-1, ruleset_fd) is always true, so the test does not check
that creating a ruleset with an empty handled_access_fs fails.  Check
for -1 instead.

Signed-off-by: Günther Noack <redacted>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261104-selftests-refactor-v2-0-c52f23f7ce33@gmail.com?part=7

Günther Noack · 2026-11-04
[PATCH v2 01/27] selftests/landlock: Propagate grandchild failures in unix_scoping · Günther Noack · 2026-11-04
Re: [PATCH v2 01/27] selftests/landlock: Propagate grandchild failures in unix_scoping · sashiko-bot@kernel.org · 2026-11-04
[PATCH v2 02/27] selftests/landlock: Propagate EXPECT failures from forked children · Günther Noack · 2026-11-04
Re: [PATCH v2 02/27] selftests/landlock: Propagate EXPECT failures from forked children · sashiko-bot@kernel.org · 2026-11-04
[PATCH v2 03/27] selftests/landlock: Check the thread result in audit.thread · Günther Noack · 2026-11-04
Re: [PATCH v2 03/27] selftests/landlock: Check the thread result in audit.thread · sashiko-bot@kernel.org · 2026-11-04
[PATCH v2 04/27] selftests/landlock: Zero-initialize the buffer in inconsistent_attr · Günther Noack · 2026-11-04
Re: [PATCH v2 04/27] selftests/landlock: Zero-initialize the buffer in inconsistent_attr · sashiko-bot@kernel.org · 2026-11-04
[PATCH v2 05/27] selftests/landlock: Fix the openat() success check in fs_bench · Günther Noack · 2026-11-04
Re: [PATCH v2 05/27] selftests/landlock: Fix the openat() success check in fs_bench · sashiko-bot@kernel.org · 2026-11-04
[PATCH v2 06/27] selftests/landlock: Fix the reported clock tick rate in fs_bench · Günther Noack · 2026-11-04
Re: [PATCH v2 06/27] selftests/landlock: Fix the reported clock tick rate in fs_bench · sashiko-bot@kernel.org · 2026-11-04
[PATCH v2 07/27] selftests/landlock: Fix the ruleset_fd check in empty_or_same_ruleset · Günther Noack · 2026-11-04
Re: [PATCH v2 07/27] selftests/landlock: Fix the ruleset_fd check in empty_or_same_ruleset · sashiko-bot@kernel.org · 2026-11-04
[PATCH v2 08/27] selftests/landlock: Handle a missing control message in recv_fd() · Günther Noack · 2026-11-04
Re: [PATCH v2 08/27] selftests/landlock: Handle a missing control message in recv_fd() · sashiko-bot@kernel.org · 2026-11-04
[PATCH v2 09/27] selftests/landlock: Assert tracefs_extract_field() results that are used · Günther Noack · 2026-11-04
Re: [PATCH v2 09/27] selftests/landlock: Assert tracefs_extract_field() results that are used · sashiko-bot@kernel.org · 2026-11-04
[PATCH v2 10/27] selftests/landlock: Assert audit initialization in fixture setups · Günther Noack · 2026-11-04
Re: [PATCH v2 10/27] selftests/landlock: Assert audit initialization in fixture setups · sashiko-bot@kernel.org · 2026-11-04
[PATCH v2 11/27] selftests/landlock: Assert helper results that are used afterwards · Günther Noack · 2026-11-04
Re: [PATCH v2 11/27] selftests/landlock: Assert helper results that are used afterwards · sashiko-bot@kernel.org · 2026-11-04
[PATCH v2 12/27] selftests/landlock: Assert audit_count_records() before using its result · Günther Noack · 2026-11-04
Re: [PATCH v2 12/27] selftests/landlock: Assert audit_count_records() before using its result · sashiko-bot@kernel.org · 2026-11-04
[PATCH v2 13/27] selftests/landlock: Fix memory leak in audit_init_filter_exe() · Günther Noack · 2026-11-04
Re: [PATCH v2 13/27] selftests/landlock: Fix memory leak in audit_init_filter_exe() · sashiko-bot@kernel.org · 2026-11-04
[PATCH v2 14/27] selftests/landlock: Make audit_message large enough for any exe filter · Günther Noack · 2026-11-04
Re: [PATCH v2 14/27] selftests/landlock: Make audit_message large enough for any exe filter · sashiko-bot@kernel.org · 2026-11-04
[PATCH v2 15/27] selftests/landlock: Close leaked file descriptors · Günther Noack · 2026-11-04
Re: [PATCH v2 15/27] selftests/landlock: Close leaked file descriptors · sashiko-bot@kernel.org · 2026-11-04
[PATCH v2 16/27] selftests/landlock: Check errno for combined VERSION and ERRATA flags · Günther Noack · 2026-11-04
Re: [PATCH v2 16/27] selftests/landlock: Check errno for combined VERSION and ERRATA flags · sashiko-bot@kernel.org · 2026-11-04
[PATCH v2 17/27] selftests/landlock: Fix SIGURG handler setup in scoped_signal_test · Günther Noack · 2026-11-04
Re: [PATCH v2 17/27] selftests/landlock: Fix SIGURG handler setup in scoped_signal_test · sashiko-bot@kernel.org · 2026-11-04
[PATCH v2 18/27] selftests/landlock: Fix regex_escape() error handling in matches_log_fs_extra() · Günther Noack · 2026-11-04
Re: [PATCH v2 18/27] selftests/landlock: Fix regex_escape() error handling in matches_log_fs_extra() · sashiko-bot@kernel.org · 2026-11-04
[PATCH v2 19/27] selftests/landlock: Fix off-by-one in regex_escape() · Günther Noack · 2026-11-04
Re: [PATCH v2 19/27] selftests/landlock: Fix off-by-one in regex_escape() · sashiko-bot@kernel.org · 2026-11-04
[PATCH v2 20/27] selftests/landlock: Fix the snprintf() error check in matches_log_fs_extra() · Günther Noack · 2026-11-04
Re: [PATCH v2 20/27] selftests/landlock: Fix the snprintf() error check in matches_log_fs_extra() · sashiko-bot@kernel.org · 2026-11-04
[PATCH v2 21/27] selftests/landlock: Use _exit() in the named_pipe_ioctl child · Günther Noack · 2026-11-04
Re: [PATCH v2 21/27] selftests/landlock: Use _exit() in the named_pipe_ioctl child · sashiko-bot@kernel.org · 2026-11-04
[PATCH v2 22/27] selftests/landlock: Fix messages and comments in helper programs · Günther Noack · 2026-11-04
Re: [PATCH v2 22/27] selftests/landlock: Fix messages and comments in helper programs · sashiko-bot@kernel.org · 2026-11-04
[PATCH v2 23/27] selftests/landlock: Fix stale comments in common.h and audit.h · Günther Noack · 2026-11-04
Re: [PATCH v2 23/27] selftests/landlock: Fix stale comments in common.h and audit.h · sashiko-bot@kernel.org · 2026-11-04
[PATCH v2 24/27] selftests/landlock: Use ASSERT for syscall failures before errno checks · Günther Noack · 2026-11-04
Re: [PATCH v2 24/27] selftests/landlock: Use ASSERT for syscall failures before errno checks · sashiko-bot@kernel.org · 2026-11-04
[PATCH v2 25/27] selftests/landlock: Assert WIFEXITED() before checking the exit status · Günther Noack · 2026-11-04
Re: [PATCH v2 25/27] selftests/landlock: Assert WIFEXITED() before checking the exit status · sashiko-bot@kernel.org · 2026-11-04
[PATCH v2 26/27] selftests/landlock: Use EXPECT for closing FDs and stopping threads · Günther Noack · 2026-11-04
Re: [PATCH v2 26/27] selftests/landlock: Use EXPECT for closing FDs and stopping threads · sashiko-bot@kernel.org · 2026-11-04
[PATCH v2 27/27] selftests/landlock: Use EXPECT for checks that later steps do not need · Günther Noack · 2026-11-04
Re: [PATCH v2 27/27] selftests/landlock: Use EXPECT for checks that later steps do not need · sashiko-bot@kernel.org · 2026-11-04
View all 55 messages

`h`	back out one level
`j`	next message in thread / next series-diff position
`k`	previous message in thread / previous series-diff position
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help