Re: [PATCH v5] Kconfig: fix typos in core makefiles and purge defective DVB debug (v5)
From: Thomas Zimmermann <tzimmermann@suse.de>
Date: 2026-09-07 06:59:39
Also in:
linux-clk, linux-fbdev, linux-input, linux-media, linux-pci, linux-sound, linux-staging, linux-usb, lkml
Please stop spamming this list with revisions. Am 05.09.26 um 02:30 schrieb Breno Rodrigues Alves:
quoted hunk ↗ jump to hunk
Automated review from Sashiko AI revealed that re-enabling the legacy DVB_ULE_DEBUG code via CONFIG_DVB_ULE_DEBUG exposes severe race conditions on global state variables, leading to out-of-bounds memory corruption. Additionally, the debug block suffers from undeclared identifiers (TS_SZ). Following the core kernel principle of eliminating dangerous, unmaintained code, this patch completely extirpates the defective DVB_ULE_DEBUG block from dvb_net.c and purges its corresponding configuration symbol from the Kconfig tree. This version retains the verified MediaTek bugfixes and ghost purges: - Fixes MediaTek interconnect typo mapping mt8196.o to MT8196. - Fixes MediaTek regulator typo mapping mt6316-regulator to MT6316. - Cleans up the dangling comment in drivers/leds/Kconfig. - Purges verified legacy ghost weight. Signed-off-by: Breno Rodrigues Alves <redacted> --- drivers/interconnect/mediatek/Makefile | 2 +- drivers/leds/Kconfig | 1 - drivers/media/dvb-core/dvb_net.c | 6 +++--- drivers/regulator/Makefile | 2 +- 4 files changed, 5 insertions(+), 6 deletions(-)diff --git a/drivers/interconnect/mediatek/Makefile b/drivers/interconnect/mediatek/Makefile index 6bd656668..64170ab16 100644 --- a/drivers/interconnect/mediatek/Makefile +++ b/drivers/interconnect/mediatek/Makefile@@ -3,4 +3,4 @@ obj-$(CONFIG_INTERCONNECT_MTK_DVFSRC_EMI) += icc-emi.o obj-$(CONFIG_INTERCONNECT_MTK_MT8183) += mt8183.o obj-$(CONFIG_INTERCONNECT_MTK_MT8195) += mt8195.o -obj-$(CONFIG_INTERCONNECT_MTK_MT8195) += mt8196.o +obj-$(CONFIG_INTERCONNECT_MTK_MT8196) += mt8196.odiff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig index d0d318223..800fbd560 100644 --- a/drivers/leds/Kconfig +++ b/drivers/leds/Kconfig@@ -873,7 +873,6 @@ config LEDS_UPBOARD This driver can also be built as a module. If so the module will be called leds-upboard. -comment "LED driver for blink(1) USB RGB LED is under Special HID drivers (HID_THINGM)" config LEDS_BLINKM tristate "LED support for the BlinkM I2C RGB LED"diff --git a/drivers/media/dvb-core/dvb_net.c b/drivers/media/dvb-core/dvb_net.c index a2159b2bc..3b503695e 100644 --- a/drivers/media/dvb-core/dvb_net.c +++ b/drivers/media/dvb-core/dvb_net.c@@ -68,7 +68,7 @@ static inline __u32 iov_crc32( __u32 c, struct kvec *iov, unsigned int cnt ) #define DVB_NET_MULTICAST_MAX 10 -#ifdef DVB_ULE_DEBUG +#ifdef CONFIG_DVB_ULE_DEBUG /* * The code inside DVB_ULE_DEBUG keeps a history of the * last 100 TS cells processed.@@ -320,7 +320,7 @@ static int dvb_net_ule_new_ts_cell(struct dvb_net_ule_handle *h) { /* We are about to process a new TS cell. */ -#ifdef DVB_ULE_DEBUG +#ifdef CONFIG_DVB_ULE_DEBUG if (ule_where >= &ule_hist[100*TS_SZ]) ule_where = ule_hist; memcpy(ule_where, h->ts, TS_SZ);@@ -659,7 +659,7 @@ static void dvb_net_ule_check_crc(struct dvb_net_ule_handle *h, h->ts_remain > 2 ? *(unsigned short *)h->from_where : 0); - #ifdef DVB_ULE_DEBUG + #ifdef CONFIG_DVB_ULE_DEBUG hexdump(iov[0].iov_base, iov[0].iov_len); hexdump(iov[1].iov_base, iov[1].iov_len); hexdump(iov[2].iov_base, iov[2].iov_len);diff --git a/drivers/regulator/Makefile b/drivers/regulator/Makefile index 5a764cec8..f81d1f31a 100644 --- a/drivers/regulator/Makefile +++ b/drivers/regulator/Makefile@@ -107,7 +107,7 @@ obj-$(CONFIG_REGULATOR_MP886X) += mp886x.o obj-$(CONFIG_REGULATOR_MPQ7920) += mpq7920.o obj-$(CONFIG_REGULATOR_MT6311) += mt6311-regulator.o obj-$(CONFIG_REGULATOR_MT6315) += mt6315-regulator.o -obj-$(CONFIG_REGULATOR_MT6315) += mt6316-regulator.o +obj-$(CONFIG_REGULATOR_MT6316) += mt6316-regulator.o obj-$(CONFIG_REGULATOR_MT6323) += mt6323-regulator.o obj-$(CONFIG_REGULATOR_MT6331) += mt6331-regulator.o obj-$(CONFIG_REGULATOR_MT6332) += mt6332-regulator.o
-- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, (HRB 36809, AG Nürnberg)