Re: [PATCH] rust: cred: update AlwaysRefCounted import to sync::aref
From: Paul Moore <paul@paul-moore.com>
Date: 2025-08-19 20:06:39
Also in:
lkml, rust-for-linux
On Mon, Aug 18, 2025 at 6:06 PM Alice Ryhl [off-list ref] wrote:
On Mon, Aug 18, 2025 at 11:22 PM Paul Moore [off-list ref] wrote:quoted
On Sun, Aug 17, 2025 at 11:26 PM Serge E. Hallyn [off-list ref] wrote:quoted
On Sat, Aug 16, 2025 at 05:14:09PM +0530, Shankari Anand wrote:quoted
Update the import of `AlwaysRefCounted` in `cred.rs` to use `sync::aref` instead of `types`.Thank you for forwarding, Miguel. As far as I can see from the included links, this looks good.quoted
This is part of the ongoing effort to move `ARef` and `AlwaysRefCounted` to the `sync` module for better modularity. Suggested-by: Benno Lossin <lossin@kernel.org> Link: https://github.com/Rust-for-Linux/linux/issues/1173 Signed-off-by: Shankari Anand <redacted>Reviewed-by: Alice Ryhl <aliceryhl@google.com>quoted
quoted
Acked-by: Serge Hallyn <serge@hallyn.com>As mentioned previously, I'm still not well versed in Rust so as long as Serge is happy with it, I'm good with it too :) I'm guessing it probably makes sense to include rust/kernel/cred.rs in the creds MAINTAINERS section just as we did (or will do) with the LSM Rust shim?That would make sense to me.
Okay, patch sent. https://lore.kernel.org/linux-security-module/20250819195841.238246-2-paul@paul-moore.com (local)
My understanding is that this patch, unlike the pin-init one, is intended to go through the LSM / CRED tree rather than taking everything through a shared tree with Acked-bys.
In that case, I've gone ahead and merged Shankari's patch into lsm/dev and will plan to send it up to Linus during the next merge window. If something changes and the Rust folks want to send this up via a Rust tree just let me know and I'll drop the patch. -- paul-moore.com