Thread (30 messages) 30 messages, 9 authors, 2025-08-10

Re: [PATCH v3 09/13] mips: Handle KCOV __init vs inline mismatch

From: Huacai Chen <chenhuacai@kernel.org>
Date: 2025-07-18 09:18:16
Also in: kvmarm, linux-arm-kernel, linux-doc, linux-efi, linux-hardening, linux-kbuild, linux-kselftest, linux-mips, linux-riscv, linux-s390, lkml, llvm, sparclinux

Reviewed-by: Huacai Chen <redacted>

On Fri, Jul 18, 2025 at 7:26 AM Kees Cook [off-list ref] wrote:
quoted hunk ↗ jump to hunk
When KCOV is enabled all functions get instrumented, unless
the __no_sanitize_coverage attribute is used. To prepare for
__no_sanitize_coverage being applied to __init functions, we
have to handle differences in how GCC's inline optimizations get
resolved. For mips this requires adding the __init annotation on
init_mips_clocksource().

Signed-off-by: Kees Cook <kees@kernel.org>
---
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: <redacted>
---
 arch/mips/include/asm/time.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/include/asm/time.h b/arch/mips/include/asm/time.h
index e855a3611d92..5e7193b759f3 100644
--- a/arch/mips/include/asm/time.h
+++ b/arch/mips/include/asm/time.h
@@ -55,7 +55,7 @@ static inline int mips_clockevent_init(void)
  */
 extern int init_r4k_clocksource(void);

-static inline int init_mips_clocksource(void)
+static inline __init int init_mips_clocksource(void)
 {
 #ifdef CONFIG_CSRC_R4K
        return init_r4k_clocksource();
--
2.34.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help