On 6/20/25 07:59, Shivank Garg wrote:

On 6/19/2025 9:33 PM, Matthew Wilcox wrote:

quoted

On Wed, Jun 18, 2025 at 11:29:31AM +0000, Shivank Garg wrote:

quoted

From: Shivansh Dhiman <redacted>

Add NUMA mempolicy support to the filemap allocation path by introducing
new APIs that take a mempolicy argument:
- filemap_grab_folio_mpol()
- filemap_alloc_folio_mpol()
- __filemap_get_folio_mpol()

You don't use these APIs in this series, so I can't evaludate whether
any of my suggestiosn for improving this patch would actually work.
NACK.  Introduce the APIs *with a user*.  Come on, this isn't a new
requirement.

Hi willy,

Thank you for the feedback.

filemap_grab_folio_mpol() is used in [Patch 6/7] in kvm_gmem_prepare_folio().

filemap_alloc_folio_mpol() and __filemap_get_folio_mpol()) are internally used
to support the filemap_grab_folio_mpol().

Maybe they can be static then and don't need to be declared in the header.

Thanks,
Shivank