On Tue, May 20, 2025 at 8:32 PM Kuniyuki Iwashima [off-list ref] wrote:

From: Stephen Smalley <stephen.smalley.work@gmail.com>
Date: Mon, 28 Apr 2025 15:50:19 -0400

quoted

Update the security_inode_listsecurity() interface to allow
use of the xattr_list_one() helper and update the hook
implementations.

Link: https://lore.kernel.org/selinux/20250424152822.2719-1-stephen.smalley.work@gmail.com/ (local)

Signed-off-by: Stephen Smalley <stephen.smalley.work@gmail.com>

[...]

quoted

diff --git a/net/socket.c b/net/socket.c
index 9a0e720f0859..bbcaa3371fcd 100644
--- a/net/socket.c
+++ b/net/socket.c

@@ -560,17 +560,14 @@ static ssize_t sockfs_listxattr(struct dentry *dentry, char *buffer,
                              size_t size)
 {
      ssize_t len;
-     ssize_t used = 0;
+     ssize_t used, remaining;
+     int err;

Paul: Could you sort this in the reverse xmas tree order before merging ?
https://docs.kernel.org/process/maintainer-netdev.html#local-variable-ordering-reverse-xmas-tree-rcs

Done, thanks for reviewing the patch.

otherwise the socket part looks good to me:

Reviewed-by: Kuniyuki Iwashima <redacted>

-- 
paul-moore.com