Re: [PATCH v17 1/3] lsm, selinux: Add setup_report permission to binder
From: Carlos Llamas <cmllamas@google.com>
Date: 2025-05-21 04:13:08
Also in:
linux-doc, lkml, netdev, selinux
From: Carlos Llamas <cmllamas@google.com>
Date: 2025-05-21 04:13:08
Also in:
linux-doc, lkml, netdev, selinux
On Tue, May 20, 2025 at 05:15:59PM -0400, Paul Moore wrote:
On Apr 16, 2025 Li Li [off-list ref] wrote:quoted
Introduce a new permission "setup_report" to the "binder" class. This persmission controls the ability to set up the binder generic netlink driver to report certain binder transactions. Signed-off-by: Thiébaud Weksteen <redacted> Signed-off-by: Li Li <redacted> --- include/linux/lsm_hook_defs.h | 1 + include/linux/security.h | 6 ++++++ security/security.c | 13 +++++++++++++ security/selinux/hooks.c | 7 +++++++ security/selinux/include/classmap.h | 3 ++- 5 files changed, 29 insertions(+), 1 deletion(-)When possible, it is helpful to include at least one caller in the patch which adds a new LSM hook as it helps put the hook in context. With that in mind, I think it would be best to reorder this patchset so that patch 2/3 comes first and this patch comes second, with this patch including the change to binder_nl_report_setup_doit() which adds the call to the new LSM hook.
Ok, I can take care for this. I'll be taking over Li's patchset now, so next version I'll reorder the series and add the caller. Thanks! -- Carlos Llamas