Re: [PATCH v2 08/11] ipv4: reorder capability check last

From
Eric Dumazet <hidden>
Date
2025-03-02 18:24:12
Also in
cocci, lkml, netdev
Reply to
Christian Göttsche, 2025-03-02
On Sun, Mar 2, 2025 at 5:07 PM Christian Göttsche
[off-list ref] wrote:
From: Christian Göttsche <redacted>

capable() calls refer to enabled LSMs whether to permit or deny the
request.  This is relevant in connection with SELinux, where a
capability check results in a policy decision and by default a denial
message on insufficient permission is issued.
It can lead to three undesired cases:
  1. A denial message is generated, even in case the operation was an
     unprivileged one and thus the syscall succeeded, creating noise.
  2. To avoid the noise from 1. the policy writer adds a rule to ignore
     those denial messages, hiding future syscalls, where the task
     performs an actual privileged operation, leading to hidden limited
     functionality of that task.
  3. To avoid the noise from 1. the policy writer adds a rule to permit
     the task the requested capability, while it does not need it,
     violating the principle of least privilege.

Signed-off-by: Christian Göttsche <redacted>
Reviewed-by: Serge Hallyn <serge@hallyn.com>
Reviewed-by: Eric Dumazet <redacted>
Thread (19 messages) 19 messages, 9 authors, last reply 2025-03-18
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help