Re: [PATCH] treewide: const qualify ctl_tables where applicable
From: "Darrick J. Wong" <djwong@kernel.org>
Date: 2025-01-09 15:51:55
Also in:
bpf, dri-devel, intel-gfx, intel-xe, io-uring, kexec, keyrings, linux-arm-kernel, linux-crypto, linux-fsdevel, linux-hardening, linux-hyperv, linux-mm, linux-nfs, linux-raid, linux-rdma, linux-riscv, linux-s390, linux-scsi, linux-serial, linux-trace-kernel, linux-xfs, linuxppc-dev, lkml, netfs, ocfs2-devel, xen-devel
On Thu, Jan 09, 2025 at 02:16:39PM +0100, Joel Granados wrote:
Add the const qualifier to all the ctl_tables in the tree except the
ones in ./net dir. The "net" sysctl code is special as it modifies the
arrays before passing it on to the registration function.
Constifying ctl_table structs will prevent the modification of
proc_handler function pointers as the arrays would reside in .rodata.
This is made possible after commit 78eb4ea25cd5 ("sysctl: treewide:
constify the ctl_table argument of proc_handlers") constified all the
proc_handlers.Sounds like a good idea, Reviewed-by: "Darrick J. Wong" <djwong@kernel.org> # xfs --D