Thread (4 messages) 4 messages, 2 authors, 2025-01-07

Re: [PATCH] KEYS: trusted: dcp: fix improper sg use with CONFIG_VMAP_STACK=y

From: "Jarkko Sakkinen" <jarkko@kernel.org>
Date: 2025-01-07 19:05:30
Also in: keyrings, linux-integrity, lkml, stable

On Tue Jan 7, 2025 at 2:56 PM EET, David Gstir wrote:
quoted
On 13.11.2024, at 22:27, David Gstir [off-list ref] wrote:

With vmalloc stack addresses enabled (CONFIG_VMAP_STACK=y) DCP trusted
keys can crash during en- and decryption of the blob encryption key via
the DCP crypto driver. This is caused by improperly using sg_init_one()
with vmalloc'd stack buffers (plain_key_blob).

Fix this by always using kmalloc() for buffers we give to the DCP crypto
driver.

Cc: stable@vger.kernel.org # v6.10+
Fixes: 0e28bf61a5f9 ("KEYS: trusted: dcp: fix leak of blob encryption key")
Signed-off-by: David Gstir <david@sigma-star.at>
gentle ping.
It's done, thanks for reminding, and don't hesitate to do it earlier
if this ever happens again.
Thanks!
- David
BR, Jarkko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help