Thread (22 messages) 22 messages, 3 authors, 2024-11-21

Re: [PATCH RFT 00/16] perf tools: Use generic syscall scripts for all archs

From: Charlie Jenkins <hidden>
Date: 2024-11-04 21:32:57
Also in: bpf, linux-arm-kernel, linux-doc, linux-perf-users, linux-riscv, lkml

On Mon, Nov 04, 2024 at 10:13:18PM +0100, Arnd Bergmann wrote:
On Mon, Nov 4, 2024, at 22:06, Charlie Jenkins wrote:
quoted
Standardize the generation of syscall headers around syscall tables.
Previously each architecture independently selected how syscall headers
would be generated, or would not define a way and fallback onto
libaudit. Convert all architectures to use a standard syscall header
generation script and allow each architecture to override the syscall
table to use if they do not use the generic table.

As a result of these changes, no architecture will require libaudit, and
so the fallback case of using libaudit is removed by this series.

Testing:

I have tested that the syscall mappings of id to name generation works
as expected for every architecture, but I have only validated that perf
trace compiles and runs as expected on riscv, arm64, and x86_64.

Signed-off-by: Charlie Jenkins <redacted>
Thanks for doing this, I had plans to do this myself, but hadn't
completed that bit so far. I'm travelling at the moment, so I'm
not sure I have time to look at it in enough detail this week.

One problem I ran into doing this previously was the incompatible
format of the tables for x86 and s390, which have conflicting
interpretations of what the '-' character means. It's possible
that this is only really relevant for the in-kernel table,
not the version in tools.
I don't think that is an issue for this usecase because the only
information that is taken from the syscall table is the number and the
name of the syscall. '-' doesn't appear in either of these columns! 

- Charlie
     Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help