Re: [PATCH v2 1/2] KEYS: use synchronous task work for changing parent credentials

[PATCH v2 0/2] get rid of cred_transfer · Jann Horn <jannh@google.com> · 2024-08-05
[PATCH v2 1/2] KEYS: use synchronous task work for changing parent credentials · Jann Horn <jannh@google.com> · 2024-08-05
Re: [PATCH v2 1/2] KEYS: use synchronous task work for changing parent credentials · "Jarkko Sakkinen" <jarkko@kernel.org> · 2024-08-15
Can KEYCTL_SESSION_TO_PARENT be dropped entirely? -- was Re: [PATCH v2 1/2] KEYS: use synchronous task work for changing parent credentials · David Howells <dhowells@redhat.com> · 2024-08-15
Re: Can KEYCTL_SESSION_TO_PARENT be dropped entirely? -- was Re: [PATCH v2 1/2] KEYS: use synchronous task work for changing parent credentials · Jann Horn <jannh@google.com> · 2024-08-15
Re: Can KEYCTL_SESSION_TO_PARENT be dropped entirely? -- was Re: [PATCH v2 1/2] KEYS: use synchronous task work for changing parent credentials · "Jarkko Sakkinen" <jarkko@kernel.org> · 2024-08-16
Re: Can KEYCTL_SESSION_TO_PARENT be dropped entirely? -- was Re: [PATCH v2 1/2] KEYS: use synchronous task work for changing parent credentials · Paul Moore <paul@paul-moore.com> · 2024-09-10
Re: Can KEYCTL_SESSION_TO_PARENT be dropped entirely? -- was Re: [PATCH v2 1/2] KEYS: use synchronous task work for changing parent credentials · Paul Moore <paul@paul-moore.com> · 2024-09-16
Re: Can KEYCTL_SESSION_TO_PARENT be dropped entirely? -- was Re: [PATCH v2 1/2] KEYS: use synchronous task work for changing parent credentials · Jann Horn <jannh@google.com> · 2024-09-16
Re: [PATCH v2 1/2] KEYS: use synchronous task work for changing parent credentials · Paul Moore <paul@paul-moore.com> · 2024-09-10
Re: [PATCH v2 1/2] KEYS: use synchronous task work for changing parent credentials · Jann Horn <jannh@google.com> · 2024-09-10
[PATCH v2 2/2] security: remove unused cred_alloc_blank/cred_transfer helpers · Jann Horn <jannh@google.com> · 2024-08-05
Re: [PATCH v2 2/2] security: remove unused cred_alloc_blank/cred_transfer helpers · "Jarkko Sakkinen" <jarkko@kernel.org> · 2024-08-15

From: Jann Horn <jannh@google.com>
Date: 2024-09-10 23:05:42
Also in: keyrings, lkml, selinux

On Tue, Sep 10, 2024 at 11:07 PM Paul Moore [off-list ref] wrote:

On Aug  5, 2024 Jann Horn [off-list ref] wrote:

quoted

-     cred->session_keyring = key_ref_to_ptr(keyring_r);
-     keyring_r = NULL;
-     init_task_work(newwork, key_change_session_keyring);
+     /* the parent mustn't be init and mustn't be a kernel thread */
+     if (is_global_init(parent) || (READ_ONCE(parent->flags) & PF_KTHREAD) != 0)
+             goto put_task;

I think we need to explicitly set @ret if we are failing here, yes?

Ah, yes. Thanks.

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help