Re: [PATCH 2/2] selinux: move genheaders to security/selinux/
From: Paul Moore <paul@paul-moore.com>
Date: 2024-08-26 21:14:43
Also in:
linux-kbuild, lkml, selinux
From: Paul Moore <paul@paul-moore.com>
Date: 2024-08-26 21:14:43
Also in:
linux-kbuild, lkml, selinux
On Aug 9, 2024 Masahiro Yamada [off-list ref] wrote:
This tool is only used in security/selinux/Makefile.
There is no reason to keep it under scripts/.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
scripts/remove-stale-files | 3 +++
scripts/selinux/Makefile | 2 +-
scripts/selinux/genheaders/.gitignore | 2 --
scripts/selinux/genheaders/Makefile | 3 ---
security/selinux/.gitignore | 1 +
security/selinux/Makefile | 7 +++++--
.../selinux/genheaders => security/selinux}/genheaders.c | 0
7 files changed, 10 insertions(+), 8 deletions(-)
delete mode 100644 scripts/selinux/genheaders/.gitignore
delete mode 100644 scripts/selinux/genheaders/Makefile
rename {scripts/selinux/genheaders => security/selinux}/genheaders.c (100%)As long as there is no harm in keeping genheaders under scripts/selinux, and based on your cover letter it would appear that there is no problem with the current location, I would prefer to keep it where it currently lives. -- paul-moore.com