Thread (15 messages) 15 messages, 3 authors, 2024-04-23
STALE777d REVIEWED: 3 (0M)
Revisions (4)
  1. v2 [diff vs current]
  2. v3 current
  3. v4 [diff vs current]
  4. v4 [diff vs current]

[PATCH v3 1/7] kunit: Handle thread creation error

From: Mickaël Salaün <mic@digikod.net>
Date: 2024-03-19 10:55:34
Also in: kvm, linux-hardening, linux-hyperv, linux-um, lkml
Subsystem: kernel unit testing framework (kunit), library code, the rest · Maintainers: Brendan Higgins, David Gow, Andrew Morton, Linus Torvalds

Previously, if a thread creation failed (e.g. -ENOMEM), the function was
called (kunit_catch_run_case or kunit_catch_run_case_cleanup) without
marking the test as failed.  Instead, fill try_result with the error
code returned by kthread_run(), which will mark the test as failed and
print "internal error occurred...".

Cc: Brendan Higgins <redacted>
Cc: Shuah Khan <skhan@linuxfoundation.org>
Reviewed-by: Kees Cook <redacted>
Reviewed-by: Rae Moar <redacted>
Reviewed-by: David Gow <redacted>
Signed-off-by: Mickaël Salaün <mic@digikod.net>
Link: https://lore.kernel.org/r/20240319104857.70783-2-mic@digikod.net (local)
---

Changes since v2:
* Add Rae's and David's Reviewed-by.

Changes since v1:
* Add Kees's Reviewed-by.
---
 lib/kunit/try-catch.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/lib/kunit/try-catch.c b/lib/kunit/try-catch.c
index f7825991d576..a5cb2ef70a25 100644
--- a/lib/kunit/try-catch.c
+++ b/lib/kunit/try-catch.c
@@ -69,6 +69,7 @@ void kunit_try_catch_run(struct kunit_try_catch *try_catch, void *context)
 				  try_catch,
 				  "kunit_try_catch_thread");
 	if (IS_ERR(task_struct)) {
+		try_catch->try_result = PTR_ERR(task_struct);
 		try_catch->catch(try_catch->context);
 		return;
 	}
-- 
2.44.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help