On Fri, Jan 05, 2024 at 06:02:38PM +0200, Jarkko Sakkinen wrote:

On Fri Jan 5, 2024 at 3:20 PM EET, Coiby Xu wrote:

quoted

On Wed, Jan 03, 2024 at 04:09:29PM +0200, Jarkko Sakkinen wrote:

quoted

On Wed Dec 27, 2023 at 6:41 AM EET, Coiby Xu wrote:

quoted

Currently when the kernel fails to add a cert to the .machine keyring,
it will throw an error immediately in the function integrity_add_key.

Since the kernel will try adding to the .platform keyring next or throw
an error (in the caller of integrity_add_key i.e. add_to_machine_keyring),
so there is no need to throw an error immediately in integrity_add_key.

Reported-by: itrymybest80@protonmail.com

Missing "Firstname Lastname".

Thanks for raising this concern! I've asked the reporter if he/she can
share his/her name.

Also, it is lacking fixes tag.

Thanks for catching this issue! I've included the Fixes tag in v2.

Fixes tag is mandatory, name part would be super nice to have :-) Since
this categories as a bug fix, getting them in is 1st priority and that
thus does not absolutely block applying the change. Thanks for going
trouble trying to query it, however.

Thanks for the explanation! As I still get no reply from the reporter,
so I guess we have to accept the name part for now.

BR, Jarkko

-- 
Best regards,
Coiby