On Tue, Nov 28, 2023 at 06:19:35AM -0800, Song Liu wrote:

Hi Christian,

On Tue, Nov 28, 2023 at 1:13 AM Christian Brauner [off-list ref] wrote:

quoted

On Mon, Nov 27, 2023 at 10:05:23AM -0800, Song Liu wrote:

[...]

quoted

quoted

Overall, we can technically add xattr_permission() check here. But I
don't think that's the right check for the LSM use case.

Does this make sense? Did I miss or misunderstand something?

If the helper is only callable from an LSM context then this should be
fine.

If everything looks good, would you please give an official Acked-by or
Reviewed-by?

Yeah looks ok to me,
Acked-by: Christian Brauner <brauner@kernel.org>