Re: [PATCH] lsm: constify 'mnt_opts' parameter in security_free_mnt_opts()
From: Paul Moore <paul@paul-moore.com>
Date: 2023-09-13 22:19:08
Also in:
lkml, llvm, oe-kbuild-all, selinux
On Wed, Aug 23, 2023 at 1:22 PM kernel test robot [off-list ref] wrote:
Hi Khadija, kernel test robot noticed the following build errors: [auto build test ERROR on pcmoore-selinux/next] [also build test ERROR on pcmoore-audit/next linus/master v6.5-rc7 next-20230823] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Khadija-Kamran/lsm-constify-mnt_opts-parameter-in-security_free_mnt_opts/20230823-170310 base: https://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/selinux.git next patch link: https://lore.kernel.org/r/ZOXG%2FVVC1XRc7TtI%40gmail.com patch subject: [PATCH] lsm: constify 'mnt_opts' parameter in security_free_mnt_opts() config: riscv-randconfig-001-20230823 (https://download.01.org/0day-ci/archive/20230824/202308240128.Gsn0b0Fv-lkp@intel.com/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce: (https://download.01.org/0day-ci/archive/20230824/202308240128.Gsn0b0Fv-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot [off-list ref] | Closes: https://lore.kernel.org/oe-kbuild-all/202308240128.Gsn0b0Fv-lkp@intel.com/ (local) All errors (new ones prefixed by >>):quoted
quoted
fs/btrfs/super.c:1523:25: error: passing 'void **' to parameter of type 'const void **' discards qualifiers in nested pointer types [-Werror,-Wincompatible-pointer-types-discards-qualifiers]security_free_mnt_opts(&new_sec_opts); ^~~~~~~~~~~~~ include/linux/security.h:301:42: note: passing argument to parameter 'mnt_opts' here void security_free_mnt_opts(const void **mnt_opts); ^ fs/btrfs/super.c:1536:25: error: passing 'void **' to parameter of type 'const void **' discards qualifiers in nested pointer types [-Werror,-Wincompatible-pointer-types-discards-qualifiers] security_free_mnt_opts(&new_sec_opts); ^~~~~~~~~~~~~ include/linux/security.h:301:42: note: passing argument to parameter 'mnt_opts' here void security_free_mnt_opts(const void **mnt_opts); ^ fs/btrfs/super.c:1699:26: error: passing 'void **' to parameter of type 'const void **' discards qualifiers in nested pointer types [-Werror,-Wincompatible-pointer-types-discards-qualifiers] security_free_mnt_opts(&new_sec_opts); ^~~~~~~~~~~~~ include/linux/security.h:301:42: note: passing argument to parameter 'mnt_opts' here void security_free_mnt_opts(const void **mnt_opts); ^ 3 errors generated.
Hi Khadija, can you check to see if these errors can be resolved? -- paul-moore.com