Thread (79 messages) 79 messages, 5 authors, 2023-08-30

Re: [PATCH 02/28] ima: Align ima_post_path_mknod() definition with LSM infrastructure

From: Stefan Berger <stefanb@linux.ibm.com>
Date: 2023-03-06 18:29:00
Also in: keyrings, linux-fsdevel, linux-integrity, linux-nfs, lkml, selinux


On 3/3/23 13:18, Roberto Sassu wrote:
From: Roberto Sassu <roberto.sassu@huawei.com>

Change ima_post_path_mknod() definition, so that it can be registered as
implementation of the path_post_mknod hook.

Also, make sure that ima_post_path_mknod() is executed only if
(mode & S_IFMT) is equal to zero or S_IFREG.

Add this check to take into account the different placement of the
path_post_mknod hook (to be introduced) in do_mknodat(). Since the new hook
will be placed after the switch(), the check ensures that
ima_post_path_mknod() is invoked as originally intended when it is
registered as implementation of path_post_mknod.
                 case 0: case S_IFREG:    <---- this here
                         error = vfs_create(mnt_userns, path.dentry->d_inode,
                                            dentry, mode, true);
                         if (!error)
                                 ima_post_path_mknod(mnt_userns, dentry);
Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com>
Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help