Re: [v2 PATCH] lib/mpi: Fix buffer overrun when SG is too long
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2022-12-23 06:25:51
Also in:
keyrings, linux-crypto, linux-integrity, lkml
On Wed, Dec 21, 2022 at 12:53:29PM -0800, Eric Biggers wrote:
That's fine, I guess. One quirk of the above approach is that if the last needed element of the scatterlist has a lot of extra pages, this will iterate through all those extra pages, processing 0 bytes from each. It could just stop when done. I suppose it's not worth worrying about that case, though.
Ideally this should be handled in the sg_miter interface, IOW, it should allow us to cap the SG list at a certain number of bytes as opposed to a certain number of entries. Cheers, -- Email: Herbert Xu [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt