Re: [PATCH v0 3/8] crypto: hbk flags & info added to the tfm
From: Jarkko Sakkinen <jarkko@kernel.org>
Date: 2022-10-12 08:58:17
Also in:
keyrings, linux-crypto, linux-integrity, lkml
What are "hbk flags & info" and "the tfm"? There can be multiple instances of struct crypto_tfm in the kernel. Maybe "crypto: Add hbk_info and is_hbk to struct crypto_tfm" ? On Thu, Oct 06, 2022 at 06:38:32PM +0530, Pankaj Gupta wrote:
Consumer of the kernel crypto api, after allocating the transformation (tfm), sets the: - flag 'is_hbk' - structure 'struct hw_bound_key_info hbk_info' based on the type of key, the consumer is using. This helps: - This helps to influence the core processing logic for the encapsulated algorithm. - This flag is set by the consumer after allocating the tfm and before calling the function crypto_xxx_setkey().
I don't really get "this helps part".
quoted hunk ↗ jump to hunk
Signed-off-by: Pankaj Gupta <pankaj.gupta@nxp.com> --- include/linux/crypto.h | 5 +++++ 1 file changed, 5 insertions(+)diff --git a/include/linux/crypto.h b/include/linux/crypto.h index 2324ab6f1846..cd476f8a1cb4 100644 --- a/include/linux/crypto.h +++ b/include/linux/crypto.h@@ -19,6 +19,7 @@ #include <linux/refcount.h> #include <linux/slab.h> #include <linux/completion.h> +#include <linux/hw_bound_key.h> /* * Autoloaded crypto modules should only use a prefixed name to avoid allowing@@ -639,6 +640,10 @@ struct crypto_tfm { u32 crt_flags; + unsigned int is_hbk;
Not sure why not just use bool as type here.
+ + struct hw_bound_key_info hbk_info; + int node; void (*exit)(struct crypto_tfm *tfm); -- 2.17.1
BR, Jarkko