Thread (2 messages) 2 messages, 2 authors, 2022-09-12

[PATCH linux-next] smack: lsm: remove the unneeded result variable

flat view
STALE1501d

From: <hidden>
Date: 2022-09-12 10:06:11
Also in: lkml
Subsystem: security subsystem, smack security module, the rest · Maintainers: Paul Moore, James Morris, "Serge E. Hallyn", Casey Schaufler, Linus Torvalds

From: Xu Panda <redacted>

Return the value smk_ptrace_rule_check() directly instead of storing it
in another redundant variable.

Reported-by: Zeal Robot <redacted>
Signed-off-by: Xu Panda <redacted>
---
 security/smack/smack_lsm.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
index 16e24a6cdc7c..b6306d71c908 100644
--- a/security/smack/smack_lsm.c
+++ b/security/smack/smack_lsm.c
@@ -497,13 +497,11 @@ static int smack_ptrace_access_check(struct task_struct *ctp, unsigned int mode)
  */
 static int smack_ptrace_traceme(struct task_struct *ptp)
 {
-       int rc;
        struct smack_known *skp;

        skp = smk_of_task(smack_cred(current_cred()));

-       rc = smk_ptrace_rule_check(ptp, skp, PTRACE_MODE_ATTACH, __func__);
-       return rc;
+       return smk_ptrace_rule_check(ptp, skp, PTRACE_MODE_ATTACH, __func__);
 }

 /**
-- 
2.15.2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help