Re: [PATCH] security/keys: Remove inconsistent __user annotation

On Thu, Sep 8, 2022 at 1:17 AM Jarkko Sakkinen [off-list ref] wrote:

On Wed, Sep 07, 2022 at 11:43:17AM -0400, Paul Moore wrote:

quoted

On Wed, Sep 7, 2022 at 10:06 AM Randy Dunlap [off-list ref] wrote:

quoted

On 9/7/22 05:12, Vincenzo Frascino wrote:

quoted

The declaration of keyring_read does not match the definition
(security/keys/keyring.c). In this case the definition is correct
because it matches what defined in "struct key_type::read"
(linux/key-type.h).

Fix the declaration removing the inconsistent __user annotation.

Cc: David Howells <dhowells@redhat.com>
Cc: Jarkko Sakkinen <jarkko@kernel.org>
Cc: Paul Moore <paul@paul-moore.com>
Cc: James Morris <jmorris@namei.org>
Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
---
Note: This issue was discovered during the porting of the linux kernel
on Morello [1].

[1] https://git.morello-project.org/morello/kernel/linux

FTR, I have sent this same patch 3 times.
Good luck.

David or Jarkko, this patch is both trivial and obviously correct,
please merge this into the keys tree for the next merge window else
I'll take it via the LSM tree.

Reviewed-by: Paul Moore <paul@paul-moore.com>

I picked it to my tree.

Thanks Jarkko.

-- 
paul-moore.com