Thread (31 messages) 31 messages, 5 authors, 2022-08-29

Re: [PATCH v14 04/10] KEYS: Move KEY_LOOKUP_ to include/linux/key.h and add flags check function

From: Jarkko Sakkinen <jarkko@kernel.org>
Date: 2022-08-28 04:00:03
Also in: bpf, keyrings, linux-doc, linux-kselftest, lkml

On Fri, Aug 26, 2022 at 11:22:54AM +0200, Roberto Sassu wrote:
On Fri, 2022-08-26 at 11:12 +0200, Roberto Sassu wrote:
quoted
From: Roberto Sassu <roberto.sassu@huawei.com>

In preparation for the patch that introduces the
bpf_lookup_user_key() eBPF
kfunc, move KEY_LOOKUP_ definitions to include/linux/key.h, to be
able to
validate the kfunc parameters.

Also, introduce key_lookup_flags_valid() to check if the caller set
in the
argument only defined flags. Introduce it directly in
include/linux/key.h,
to reduce the risk that the check is not in sync with currently
defined
flags.

Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com>
Reviewed-by: KP Singh <kpsingh@kernel.org>
Jarkko, could you please ack it if it is fine?
So, as said I'm not really confident that a function is
even needed in the first place. It's fine if there are
enough call sites to make it legit.

BR, Jarkko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help