Re: [PATCH v4 3/3] gen_init_cpio: add support for file metadata
From: Eugeniu Rosca <hidden>
Date: 2022-06-16 15:16:15
Also in:
linux-api, linux-fsdevel, linux-integrity, lkml
Hello Roberto, On Do, Mai 23, 2019 at 02:18:03 +0200, Roberto Sassu wrote:
quoted hunk ↗ jump to hunk
This patch adds support for file metadata (only TYPE_XATTR metadata type). gen_init_cpio has been modified to read xattrs from files that will be added to the image and to include file metadata as separate files with the special name 'METADATA!!!'. This behavior can be selected by setting the desired file metadata type as value for CONFIG_INITRAMFS_FILE_METADATA. Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com> --- usr/Kconfig | 8 +++ usr/Makefile | 4 +- usr/gen_init_cpio.c | 137 ++++++++++++++++++++++++++++++++++++-- usr/gen_initramfs_list.sh | 10 ++- 4 files changed, 150 insertions(+), 9 deletions(-)diff --git a/usr/gen_init_cpio.c b/usr/gen_init_cpio.c
[..]
+static int write_xattrs(const char *path)
+{[..]
+ while (list_ptr < xattr_list + list_len) {
+ name_len = strlen(list_ptr);PVS-Studio 7.19 reports at this line: => usr/gen_init_cpio.c 84 warn V769 => The 'xattr_list' pointer in the 'xattr_list + list_len' expression could be nullptr. => In such case, resulting value will be senseless and it should not be used. Check lines: 84, 69. I guess the finding is valid and it's due to the fact that the malloc return value is not being checked/sanitized? BR, Eugeniu.