Re: [PATCH v4 2/3] LoadPin: Enable loading from trusted dm-verity devices
From: Matthias Kaehlcke <mka@chromium.org>
Date: 2022-05-18 14:41:19
Also in:
dm-devel, linux-raid, lkml, oe-kbuild-all
On Wed, May 18, 2022 at 04:58:06PM +0800, kernel test robot wrote:
Hi Matthias, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on device-mapper-dm/for-next] [also build test WARNING on song-md/md-next kees/for-next/pstore linus/master v5.18-rc7 next-20220517] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Matthias-Kaehlcke/LoadPin-Enable-loading-from-trusted-dm-verity-devices/20220518-073635 base: https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git for-next config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20220518/202205181616.3eTP2DaC-lkp@intel.com/config) compiler: m68k-linux-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/755e5d82e4d054b2b58a54c94681080cc8cb4582 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Matthias-Kaehlcke/LoadPin-Enable-loading-from-trusted-dm-verity-devices/20220518-073635 git checkout 755e5d82e4d054b2b58a54c94681080cc8cb4582 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash security/loadpin/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <redacted> All warnings (new ones prefixed by >>): In file included from security/loadpin/loadpin.c:21: include/linux/dm-verity-loadpin.h:22:1: error: expected identifier or '(' before '{' token 22 | { | ^quoted
quoted
include/linux/dm-verity-loadpin.h:21:20: warning: 'dm_verity_loadpin_is_sb_trusted' used but never defined21 | static inline bool dm_verity_loadpin_is_sb_trusted(struct super_block *sb); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ vim +/dm_verity_loadpin_is_sb_trusted +21 include/linux/dm-verity-loadpin.h afd03270f57b8c Matthias Kaehlcke 2022-05-17 17 afd03270f57b8c Matthias Kaehlcke 2022-05-17 18 #if IS_ENABLED(CONFIG_SECURITY_LOADPIN) && IS_BUILTIN(CONFIG_DM_VERITY) afd03270f57b8c Matthias Kaehlcke 2022-05-17 19 bool dm_verity_loadpin_is_sb_trusted(struct super_block *sb); afd03270f57b8c Matthias Kaehlcke 2022-05-17 20 #else afd03270f57b8c Matthias Kaehlcke 2022-05-17 @21 static inline bool dm_verity_loadpin_is_sb_trusted(struct super_block *sb); afd03270f57b8c Matthias Kaehlcke 2022-05-17 @22 { afd03270f57b8c Matthias Kaehlcke 2022-05-17 23 return false; afd03270f57b8c Matthias Kaehlcke 2022-05-17 24 } afd03270f57b8c Matthias Kaehlcke 2022-05-17 25 #endif afd03270f57b8c Matthias Kaehlcke 2022-05-17 26
Oops, will fix