Re: [PATCH v19 1/4] Add flags option to get xattr method paired to __vfs_getxattr

From
Paul Moore <paul@paul-moore.com>
Date
2022-03-25 14:44:47
Also in
linux-fsdevel, linux-unionfs, lkml, selinux
Reply to
Luca Weiss, 2022-03-25
On Fri, Mar 25, 2022 at 7:02 AM Luca Weiss [off-list ref] wrote:
Hi David,

this patch doesn't compile with CONFIG_SECURITY=n:

./include/linux/security.h: In function 'security_inode_need_killpriv':
./include/linux/security.h:893:40: error: passing argument 1 of 'cap_inode_need_killpriv' from incompatible pointer type [-Werror=incompatible-pointer-types]
  893 |         return cap_inode_need_killpriv(dentry);
      |                                        ^~~~~~
      |                                        |
      |                                        struct dentry *
./include/linux/security.h:153:52: note: expected 'struct user_namespace *' but argument is of type 'struct dentry *'
  153 | int cap_inode_need_killpriv(struct user_namespace *mnt_userns,
      |                             ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~

I applied the patch on linux-next tag next-20220318, but the relevant part
doesn't seem to have changed lately.
I believe David (and Google) have abandoned this patchset in favor of
another approach.  I'm possibly going to recycle some of the ideas in
this patchset for some future work, but the details are still TBD.

-- 
paul-moore.com
Thread (21 messages) 21 messages, 7 authors, last reply 2025-02-25
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help