Thread (23 messages) 23 messages, 5 authors, 2022-02-28

Re: [PATCH v2 1/6] ima: Fix documentation-related warnings in ima_main.c

From: Shuah Khan <skhan@linuxfoundation.org>
Date: 2022-02-15 15:47:26
Also in: bpf, linux-integrity, linux-kselftest, lkml, netdev

On 2/15/22 5:40 AM, Roberto Sassu wrote:
Fix some warnings in ima_main.c, displayed with W=n make argument.
Thank you for fixing these. Doc builds are full of them and few less
is welcome.

Adding the warns or summary of them to change log will be good.
quoted hunk ↗ jump to hunk
Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com>
---
  security/integrity/ima/ima_main.c | 11 ++++++-----
  1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c
index 8c6e4514d494..946ba8a12eab 100644
--- a/security/integrity/ima/ima_main.c
+++ b/security/integrity/ima/ima_main.c
@@ -418,6 +418,7 @@ int ima_file_mmap(struct file *file, unsigned long prot)
  
  /**
   * ima_file_mprotect - based on policy, limit mprotect change
+ * @vma: vm_area_struct protection is set to
   * @prot: contains the protection that will be applied by the kernel.
   *

Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>

thanks,
-- Shuah
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help