Re: [PATCH v2 2/6] powerpc/kexec_file: Add KEXEC_SIG support.

Hello,

On Wed, Dec 08, 2021 at 08:51:47PM -0500, Nayna wrote:

On 11/25/21 13:02, Michal Suchanek wrote:

quoted

Copy the code from s390x

Signed-off-by: Michal Suchanek<redacted>
---
  arch/powerpc/Kconfig        | 11 +++++++++++
  arch/powerpc/kexec/elf_64.c | 36 ++++++++++++++++++++++++++++++++++++
  2 files changed, 47 insertions(+)

diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index ac0c515552fd..ecc1227a77f1 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig

@@ -561,6 +561,17 @@ config KEXEC_FILE
  config ARCH_HAS_KEXEC_PURGATORY
  	def_bool KEXEC_FILE

+config KEXEC_SIG
+	bool "Verify kernel signature during kexec_file_load() syscall"
+	depends on KEXEC_FILE && MODULE_SIG_FORMAT

After manually applying the patch, the build is failing with the following
error:

build failed with error "arch/powerpc/kexec/elf_64.o: In function
`elf64_verify_sig':
/root/kernel/linus/linux/arch/powerpc/kexec/elf_64.c:160: undefined
reference to `verify_appended_signature'"

This patch does not add call to verify_appended_signature.

Maybe you applied the following patch as well?

Thanks

Michal

On 12/9/21 04:21, Michal Suchánek wrote:

Hello,

Hi,

On Wed, Dec 08, 2021 at 08:51:47PM -0500, Nayna wrote:

quoted

On 11/25/21 13:02, Michal Suchanek wrote:

quoted

Copy the code from s390x

Signed-off-by: Michal Suchanek<redacted>
---
   arch/powerpc/Kconfig        | 11 +++++++++++
   arch/powerpc/kexec/elf_64.c | 36 ++++++++++++++++++++++++++++++++++++
   2 files changed, 47 insertions(+)

diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index ac0c515552fd..ecc1227a77f1 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig

@@ -561,6 +561,17 @@ config KEXEC_FILE
   config ARCH_HAS_KEXEC_PURGATORY
   	def_bool KEXEC_FILE

+config KEXEC_SIG
+	bool "Verify kernel signature during kexec_file_load() syscall"
+	depends on KEXEC_FILE && MODULE_SIG_FORMAT

After manually applying the patch, the build is failing with the following
error:

build failed with error "arch/powerpc/kexec/elf_64.o: In function
`elf64_verify_sig':
/root/kernel/linus/linux/arch/powerpc/kexec/elf_64.c:160: undefined
reference to `verify_appended_signature'"

This patch does not add call to verify_appended_signature.

Maybe you applied the following patch as well?

Yes, I tried build after applying all the patches.

Thanks & Regards,

     - Nayna