Thread (3 messages) 3 messages, 2 authors, 2021-12-01

Re: [PATCH v4] KEYS: trusted: Fix trusted key backends when building as module

flat view

From: Jarkko Sakkinen <jarkko@kernel.org>
Date: 2021-12-01 10:40:11
Also in: keyrings, linux-integrity, lkml

On Wed, Dec 01, 2021 at 10:59:00AM +0100, Ahmad Fatoum wrote:
From: Andreas Rammhold <redacted>

Before this commit the kernel could end up with no trusted key sources
even though both of the currently supported backends (TPM and TEE) were
compiled as modules. This manifested in the trusted key type not being
registered at all.

When checking if a CONFIG_… preprocessor variable is defined we only
test for the builtin (=y) case and not the module (=m) case. By using
the IS_REACHABLE() macro we do test for both cases.

Fixes: 5d0682be3189 ("KEYS: trusted: Add generic trusted keys framework")
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Reviewed-by: Sumit Garg <redacted>
Signed-off-by: Andreas Rammhold <redacted>
Tested-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Thank you, I picked this.

/Jarkko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help