Re: [PATCH] Revert "net: fix NULL pointer reference in cipso_v4_doi_free"

On Thu, Sep 2, 2021 at 10:31 PM 王贇 [off-list ref] wrote:

On 2021/9/3 上午10:15, Paul Moore wrote:
[snip]

quoted

quoted

both v1 and v2 are there with the same description and both code modification
are applied.

We want revert v1 but not in a revert patch style, then do you suggest
send a normal patch to do the code revert?

It sounds like DaveM wants you to create a normal (not a revert) patch
that removes the v1 changes while leaving the v2 changes intact.  In
the patch description you can mention that v1 was merged as a mistake
and that v2 is the correct fix (provide commit IDs for each in your
commit description using the usual 12-char hash snippet followed by
the subject in parens-and-quotes).

Thanks for the kindly explain, I've sent:
  [PATCH] net: remove the unnecessary check in cipso_v4_doi_free

Which actually revert the v1 and mentioned v2 fixed the root casue,
Would you please take a look see if that is helpful?

That looks correct to me, acked.  Thanks.

-- 
paul moore
www.paul-moore.com