Re: [PATCH 1/2] audit: add filtering for io_uring records, addendum

Hi Richard,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on pcmoore-audit/next]
[also build test ERROR on v5.13-rc4 next-20210528]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Richard-Guy-Briggs/audit-add-filtering-for-io_uring-records-addendum/20210531-214941
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/audit.git next
config: parisc-randconfig-r015-20210531 (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/07a3e22a2f984838bc98b43b58e8ef08e9353483
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Richard-Guy-Briggs/audit-add-filtering-for-io_uring-records-addendum/20210531-214941
        git checkout 07a3e22a2f984838bc98b43b58e8ef08e9353483
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <redacted>

All errors (new ones prefixed by >>):

   kernel/auditfilter.c: In function 'audit_to_inode':

quoted

kernel/auditfilter.c:155:24: error: 'AUDIT_FILTER_URING_EXIT' undeclared (first use in this function); did you mean 'AUDIT_FILTER_EXIT'?

     155 |       krule->listnr != AUDIT_FILTER_URING_EXIT) ||
         |                        ^~~~~~~~~~~~~~~~~~~~~~~
         |                        AUDIT_FILTER_EXIT
   kernel/auditfilter.c:155:24: note: each undeclared identifier is reported only once for each function it appears in
   kernel/auditfilter.c: In function 'audit_to_entry_common':
   kernel/auditfilter.c:252:7: error: 'AUDIT_FILTER_URING_EXIT' undeclared (first use in this function); did you mean 'AUDIT_FILTER_EXIT'?
     252 |  case AUDIT_FILTER_URING_EXIT:
         |       ^~~~~~~~~~~~~~~~~~~~~~~
         |       AUDIT_FILTER_EXIT
   kernel/auditfilter.c: In function 'audit_add_rule':
   kernel/auditfilter.c:986:28: error: 'AUDIT_FILTER_URING_EXIT' undeclared (first use in this function); did you mean 'AUDIT_FILTER_EXIT'?
     986 |      entry->rule.listnr == AUDIT_FILTER_URING_EXIT) {
         |                            ^~~~~~~~~~~~~~~~~~~~~~~
         |                            AUDIT_FILTER_EXIT
--
   kernel/audit_watch.c: In function 'audit_to_watch':

quoted

kernel/audit_watch.c:187:24: error: 'AUDIT_FILTER_URING_EXIT' undeclared (first use in this function); did you mean 'AUDIT_FILTER_EXIT'?

     187 |       krule->listnr != AUDIT_FILTER_URING_EXIT) ||
         |                        ^~~~~~~~~~~~~~~~~~~~~~~
         |                        AUDIT_FILTER_EXIT
   kernel/audit_watch.c:187:24: note: each undeclared identifier is reported only once for each function it appears in
--
   kernel/audit_tree.c: In function 'audit_make_tree':

quoted

kernel/audit_tree.c:731:23: error: 'AUDIT_FILTER_URING_EXIT' undeclared (first use in this function); did you mean 'AUDIT_FILTER_EXIT'?

     731 |       rule->listnr != AUDIT_FILTER_URING_EXIT) ||
         |                       ^~~~~~~~~~~~~~~~~~~~~~~
         |                       AUDIT_FILTER_EXIT
   kernel/audit_tree.c:731:23: note: each undeclared identifier is reported only once for each function it appears in


vim +155 kernel/auditfilter.c

   149	
   150	/* Translate an inode field to kernel representation. */
   151	static inline int audit_to_inode(struct audit_krule *krule,
   152					 struct audit_field *f)
   153	{
   154		if ((krule->listnr != AUDIT_FILTER_EXIT &&
 > 155		     krule->listnr != AUDIT_FILTER_URING_EXIT) ||
   156		    krule->inode_f || krule->watch || krule->tree ||
   157		    (f->op != Audit_equal && f->op != Audit_not_equal))
   158			return -EINVAL;
   159	
   160		krule->inode_f = f;
   161		return 0;
   162	}
   163	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org