Thread (3 messages) 3 messages, 2 authors, 2021-04-19

Re: [PATCH] lsm:fix a missing-check bug in smack_sb_eat_lsm_opts()

From: Zhongjun Tan <hidden>
Date: 2021-04-19 02:59:37
Also in: lkml

On Fri, 16 Apr 2021 13:36:01 +0000
Al Viro [off-list ref] wrote:
On Fri, Apr 16, 2021 at 05:53:03PM +0800,  Zhongjun Tan wrote:
quoted
@@ -710,13 +711,14 @@ static int smack_sb_eat_lsm_opts(char
*options, void **mnt_opts) token = match_opt_prefix(from, len,
&arg); if (token != Opt_error) {
 			arg = kmemdup_nul(arg, from + len - arg,
GFP_KERNEL);
+			if (!arg) {
+				rc = -ENOMEM;
+				goto free_mnt_opts;
 			rc = smack_add_opt(token, arg, mnt_opts);  
			if (arg)
	  			rc = smack_add_opt(token, arg,
mnt_opts); else
				rc = -ENOMEM;

and no other changes are needed anywhere...
update patch v3 , just four codes and no other changes are needed. 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help